fix: parse JSON strings to objects before final serialization #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test:uipath-langchain
saksharthakkar
force-pushed
the
fix/temporal-attribute-parity
branch
from
581dee2 to
ecba87e
Compare
cotovanu-cristian
approved these changes
Jan 16, 2026
ionmincu
approved these changes
Jan 16, 2026
OTEL only accepts primitives, so agents serialize dicts to JSON strings. This caused double-encoding when the exporter serialized the entire Attributes dict. Parse these fields back to objects before final serialization to match Temporal schema (inputSchema, outputSchema, settings, toolCalls, usage as objects not escaped strings). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Detect any string starting with { or [ and parse as JSON.
More maintainable - no need to update field list when new attributes added.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add test_json_strings_parsed_to_objects to verify JSON-encoded strings
starting with { or [ are parsed to objects before final serialization
- Remove docs/plans/proposal-interruptible-trace-context.md (unrelated)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
saksharthakkar
force-pushed
the
fix/temporal-attribute-parity
branch
from
52b2af7 to
3da3a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
inputSchema,outputSchema,settings,toolCalls,usagewere escaped strings instead of objectsTest plan
##Before
Screen.Recording.2026-01-15.at.3.17.04.PM.mov
##After
🤖 Generated with Claude Code